This repository has been archived by the owner on Apr 17, 2018. It is now read-only.
Uniqueness check should only be skipped if the field is blank #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkubb Wondering if there's any specific reason if this was closed? I'd be willing to fix any merge issues if you still would like the PR :) |
|
@pnomolos it was probably closed because the release-1.2 branch was removed. I didn't intentionally set out to close this PR. If you want to reopen a PR against the master branch we can look at testing it and merging it in. One requirement is that the build continue to pass (or if it is failing, not for there to be a regression where more tests fail than before). We'll have all the builds passing shortly that aren't. The main reason for the release-1.2 branch removal was simply because we wanted to get all dev being done against the master branch and not fragment development further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default behaviour for the uniqueness validator is to skip over a field if it is allowed to be blank or nil. It should only skip those fields if they are also set to blank, otherwise uniqueness errors can occur. Attached is a fix and an updated spec.